Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): add JSII_NODE to override node entrypoint #3890

Merged
merged 6 commits into from
Feb 16, 2023
Merged

Conversation

dastbe
Copy link
Contributor

@dastbe dastbe commented Dec 23, 2022

By default, jsii-go will lookup the node entrypoint from the PATH. This allows users to override with a specific node entrypoint via the JSII_NODE environment variable.

issue: #3889


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

By default, jsii-go will lookup the node entrypoint from the PATH. This
allows users to override with a specific node entrypoint via the
JSII_NODE environment variable.
@dastbe dastbe changed the title feat(go): add JSII_NODE to override node entrypoint fixes: #3889 feat(go): add JSII_NODE to override node entrypoint Dec 23, 2022
RomainMuller
RomainMuller previously approved these changes Feb 16, 2023
@mergify mergify bot dismissed RomainMuller’s stale review February 16, 2023 12:00

Pull request has been modified.

RomainMuller
RomainMuller previously approved these changes Feb 16, 2023
@mergify mergify bot dismissed RomainMuller’s stale review February 16, 2023 14:10

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Feb 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

Merging (with squash)...

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

Merging (with squash)...

@mergify mergify bot merged commit 357562a into aws:main Feb 16, 2023
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Feb 16, 2023
@osdrv osdrv mentioned this pull request Mar 21, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants