Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE to Apache-2.0 #114

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Update LICENSE to Apache-2.0 #114

merged 2 commits into from
Jul 31, 2018

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jul 31, 2018

Fixes awslabs/cdk-ops#34

By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.

Fixes awslabs/cdk-ops#34
@eladb eladb requested a review from RomainMuller July 31, 2018 09:43
@@ -1,2 +1 @@
By submitting this pull request, I confirm that my contribution is made under
the terms of the beta license.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just copy the one from aws-cdk? It uses the SPDX standard name Apache-2.0 and has a link to the full license, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just pushed a commit that removes this link. It's messy when it's included in everyone's pull requests. I prefer this to be kept concise and simple.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay.

LICENSE Outdated
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to replace the parts between [] with relevant values...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. sure

same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@eladb eladb merged commit 22da82e into master Jul 31, 2018
@eladb eladb deleted the benisrae/apache-license branch July 31, 2018 10:05
mpiroc pushed a commit that referenced this pull request Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants