chore(go): emit one file per type #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of generating one file will ALL the types in a given (sub)module, emit one file per type within the (sub)module, so that the compiler operates on smaller compilation units. This should reduce the memory pressure the compiler experiences when dealing with large libraries.
|
Nice! This should help with hashicorp/terraform-cdk#1886 |
comcalvi
reviewed
Aug 4, 2022
RomainMuller
force-pushed
the
rmuller/go-file-per-class
branch
from
f9e4f2c
to
7122840
Compare
comcalvi
approved these changes
Aug 9, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
…lass # Conflicts: # packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.js.snap
|
Merging (with squash)... |
RomainMuller
added a commit
that referenced
this pull request
Aug 10, 2022
Instead of generating one file will ALL the types in a given (sub)module, emit one file per type within the (sub)module, so that the compiler operates on smaller compilation units. This should reduce the memory pressure the compiler experiences when dealing with large libraries. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating one file will ALL the types in a given
(sub)module, emit one file per type within the (sub)module,
so that the compiler operates on smaller compilation units.
This should reduce the memory pressure the compiler
experiences when dealing with large libraries.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.