fix: JSII_RUNTIME_PACKAGE_CACHE improper case bug #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged. |
Ragnoroct
changed the title
RomainMuller
previously approved these changes
Feb 3, 2023
| @@ -24,7 +24,7 @@ export interface ExtractResult { | |||
| } | |||
|
|
|||
| let packageCacheEnabled = | |||
| process.env.JSII_RUNTIME_PACKAGE_CACHE?.toLocaleUpperCase() === 'enabled'; | |||
| process.env.JSII_RUNTIME_PACKAGE_CACHE?.toLocaleLowerCase() === 'enabled'; | |||
|
Thank you for contributing! 鉂わ笍 I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
mergify
bot
dismissed
RomainMuller鈥檚 stale review
Pull request has been modified.
RomainMuller
approved these changes
Feb 16, 2023
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where cached enabled is always false.
fixes #3911
It took me a good 4 minutes to figure out that the PR title needs a to be prefixed with
fix:including the colon 馃槃By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.