Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii): check that static and nonstatic members don't share a name #430

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 4, 2019

This is not allowed in Java, and leads to compiler warnings in C#.

Fixes #427.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is not allowed in Java, and leads to compiler warnings in C#.

Fixes #427.
@rix0rrr rix0rrr requested a review from a team as a code owner April 4, 2019 09:27
@@ -0,0 +1,17 @@
///!MATCH_ERROR: non-static member 'funFunction' of class 'Sub' conflicts with static member in ancestor 'SuperDuper'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the case where I try to declare both on the same class?

@rix0rrr rix0rrr merged commit a0741cc into master Apr 4, 2019
@rix0rrr rix0rrr deleted the huijbers/jsii-static-checks branch April 4, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants