Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix typo in go helper function Doc Comment #4381

Merged
merged 9 commits into from Jan 11, 2024
Merged

Conversation

PeteXC
Copy link
Contributor

@PeteXC PeteXC commented Dec 21, 2023


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

mergify bot commented Dec 21, 2023

The title of this Pull Request does not conform with [Conventional Commits] guidelines. It will need to be adjusted before the PR can be merged.
[Conventional Commits]: https://www.conventionalcommits.org

@PeteXC PeteXC changed the title fix typo in go helper function Doc Comment docs: fix typo in go helper function Doc Comment Dec 21, 2023
@PeteXC PeteXC changed the title docs: fix typo in go helper function Doc Comment chore(docs): fix typo in go helper function Doc Comment Dec 21, 2023
mrgrain
mrgrain previously approved these changes Jan 9, 2024
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Jan 9, 2024
@mergify mergify bot dismissed mrgrain’s stale review January 9, 2024 11:40

Pull request has been modified.

@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Jan 9, 2024
mrgrain
mrgrain previously approved these changes Jan 9, 2024
Copy link
Contributor

mergify bot commented Jan 9, 2024

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jan 9, 2024
Copy link
Contributor

mergify bot commented Jan 9, 2024

Merging (with squash)...

@mergify mergify bot dismissed mrgrain’s stale review January 11, 2024 09:47

Pull request has been modified.

Copy link
Contributor

mergify bot commented Jan 11, 2024

Merging (with squash)...

Copy link
Contributor

mergify bot commented Jan 11, 2024

Merging (with squash)...

@mergify mergify bot merged commit 880fc2d into aws:main Jan 11, 2024
28 checks passed
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants