chore: upgrade to @types/node 10.x #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually upgrade the `node` engine support to 10.x tree, as has been declared in the `package.json` files for a month now. Additionally, standardized the `compilerOptions` in the `tsconfig.json` files that are *not* generated by `jsii`, in order to use `ES2018` standard library, enable `strict` mode (this includes `strictPropertyInitialization`, which was not enabled previously and required a few code changes in `jsii-pacmak` that were made ad-minima). The library clause of `tsconfig.json` files that are generated by `jsii` has not been changed yet. This means you need to use `node >= 10.x` in order to use `jsii`, but you cannot use it to build code that depend on APIs that are not yet available in `node 8`. This behavior will be updated in a second phase. Related: #794
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
reviewed
Oct 17, 2019
|
@nija-at so I have ran a full build of |
nija-at
approved these changes
Oct 18, 2019
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually upgrade the
nodeengine support to 10.x tree, as hasbeen declared in the
package.jsonfiles for a month now.Additionally, standardized the
compilerOptionsin thetsconfig.jsonfilesthat are not generated by
jsii, in order to useES2018standard library,enable
strictmode (this includesstrictPropertyInitialization, which was notenabled previously and required a few code changes in
jsii-pacmakthat weremade ad-minima).
The library clause of
tsconfig.jsonfiles that are generated byjsiihas notbeen changed yet. This means you need to use
node >= 10.xin order to usejsii, but you cannot use it to build code that depend on APIs that are not yetavailable in
node 8. This behavior will be updated in a second phase.Fixes #794
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.