Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v0.20.6 #989

Merged
merged 2 commits into from
Nov 14, 2019
Merged

release: v0.20.6 #989

merged 2 commits into from
Nov 14, 2019

Conversation

RomainMuller
Copy link
Contributor

The Dyanmic proxies were missing an implementation of __setattr__,
which caused setter invokations to not be forwarded to the node
process.

This is what causes aws/aws-cdk#5032


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The Dyanmic proxies were missing an implementation of `__setattr__`,
which caused setter invokations to not be forwarded to the `node`
process.

This is what causes aws/aws-cdk#5032
@RomainMuller RomainMuller requested review from bmaizels and a team as code owners November 14, 2019 16:57
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

See CHANGELOG
@RomainMuller RomainMuller changed the title fix(python): dynamic proxies handling of setters release: v0.20.6 Nov 14, 2019
@RomainMuller RomainMuller removed the request for review from bmaizels November 14, 2019 17:07
@RomainMuller RomainMuller merged commit 17f281e into patch-release Nov 14, 2019
@RomainMuller RomainMuller deleted the rmuller/v0.20.6 branch November 14, 2019 17:15
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify bot pushed a commit that referenced this pull request Nov 14, 2019
The Dyanmic proxies were missing an implementation of `__setattr__`,
which caused setter invokations to not be forwarded to the `node`
process.

This is what causes aws/aws-cdk#5032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants