Enforce error checking in CI (#1417)

* enforce err check
aws · Feb 25, 2022 · 40f002e · 40f002e
1 parent 2396c10
commit 40f002e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -25,7 +25,6 @@ linters:
     - unconvert
     - unparam
   disable:
-    - errcheck
     - prealloc
 
   linters-settings:

diff --git a/pkg/test/expectations/expectations.go b/pkg/test/expectations/expectations.go
@@ -179,7 +179,9 @@ func ExpectProvisioned(ctx context.Context, c client.Client, selectionController
 	for _, pod := range pods {
 		wg.Add(1)
 		go func(pod *v1.Pod) {
-			selectionController.Reconcile(ctx, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(pod)})
+			if _, err := selectionController.Reconcile(ctx, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(pod)}); err != nil {
+				Expect(err).To(HaveOccurred()) // This is expected to sometimes happen
+			}
 			wg.Done()
 		}(pod)
 	}