Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope provisioner to only serve specified namespaces #1493

Closed
robertd opened this issue Mar 9, 2022 · 3 comments · Fixed by #1509
Closed

Scope provisioner to only serve specified namespaces #1493

robertd opened this issue Mar 9, 2022 · 3 comments · Fixed by #1509
Assignees
Labels
feature New feature or request

Comments

@robertd
Copy link
Contributor

robertd commented Mar 9, 2022

Tell us about your request
What do you want us to build?

We're playing around with setting up an OpenFaaS (openfaas.io) on top of an EKS cluster w/ Karpenter installed... so namespace-based provisioner "awareness" would be a nice addition.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

This would allow provisioners to only serve specific namespaces (1 to n) and create the underlying nodes for the incoming workloads.

Are you currently working around this issue?
How are you currently solving this problem?
N/A

Additional context
Anything else we should know?
N/A

Attachments
If you think you might have additional information that you'd like to include via an attachment, please do - we'll take a look. (Remember to remove any personally-identifiable information.)

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

cc @ellistarn

@robertd robertd added the feature New feature or request label Mar 9, 2022
@bwagner5
Copy link
Contributor

bwagner5 commented Mar 9, 2022

Thanks for the feature request!

Curious on yours and others thoughts on adding the namespace as a field in the provisioner spec (seems a little dirty) vs creating a NamedspacedProvisioner CRD? We definitely want to maintain the current semantic of a global provisioner.

@ellistarn
Copy link
Contributor

@bwagner5 I think we need a NamespaceSelector, similar to pod affinity rules. I'd push back pretty hard about making provisioners namespaced, since they own nodes that are global. Even worse to have multiple CRs.

@robertd
Copy link
Contributor Author

robertd commented Mar 10, 2022

+1 for NamespaceSelector... Is it too much to ask if it can handle multiple namespaces at once (array of namespaces)? TIA

@tzneal tzneal self-assigned this Mar 10, 2022
@tzneal tzneal added this to In progress in Engineering - Mar 2022 Mar 10, 2022
tzneal added a commit to tzneal/karpenter that referenced this issue Mar 10, 2022
This is modeled after the NamespaceSelector on pod affinity terms
and works the same way.

Fixes aws#1493
tzneal added a commit to tzneal/karpenter that referenced this issue Mar 10, 2022
This is modeled after the NamespaceSelector on pod affinity terms
and works the same way.

Fixes aws#1493
tzneal added a commit to tzneal/karpenter that referenced this issue Mar 10, 2022
This is modeled after the NamespaceSelector on pod affinity terms
and works the same way.

Fixes aws#1493
@robertd robertd changed the title Ability for a provisioner to "listen" for and respond to changes in a specific namespace only Scope provisioner to serve a specified namespaces only Mar 10, 2022
@robertd robertd changed the title Scope provisioner to serve a specified namespaces only Scope provisioner to serve specified namespaces only Mar 10, 2022
@robertd robertd changed the title Scope provisioner to serve specified namespaces only Scope provisioner to only serve specified namespaces Mar 11, 2022
tzneal added a commit to tzneal/karpenter that referenced this issue Mar 14, 2022
tzneal added a commit to tzneal/karpenter that referenced this issue Mar 14, 2022
tzneal added a commit to tzneal/karpenter that referenced this issue Mar 14, 2022
@tzneal tzneal moved this from In progress to Done in Engineering - Mar 2022 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
No open projects
4 participants