Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a label for CPU Manufacturer/Name #3529

Closed
zbintliff opened this issue Mar 3, 2023 · 1 comment · Fixed by #5769
Closed

Add a label for CPU Manufacturer/Name #3529

zbintliff opened this issue Mar 3, 2023 · 1 comment · Fixed by #5769
Labels
feature New feature or request good-first-issue Good for newcomers

Comments

@zbintliff
Copy link

Tell us about your request

Similar to how you provide karpenter.k8s.aws/instance-gpu-manufacturer it would be great to have one for CPU manufacterer. We have a use case where workloads are using intel specific features and want to target i nodes vs a nodes. Right now the labels show they are just arch amd64 for both, which means we need to define specific instance types and update them as new generations come out.

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

We have come workloads that only want to go on intel based instances. Right now we have our own metadata to add this type of information but would be great if it was "free".

Are you currently working around this issue?

During startup we parse the output of lscpu to determine amd vs intel

Additional Context

No response

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@zbintliff zbintliff added the feature New feature or request label Mar 3, 2023
@sftim
Copy link
Contributor

sftim commented Jun 5, 2023

Although Karpenter could do the labelling, you could also have a Provisioner with an allow list of instance types (which is already supported) and then use node feature discovery to add the labels you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good-first-issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants