Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo refactor guides #1444

Closed
wants to merge 6 commits into from
Closed

Conversation

geoffcline
Copy link
Contributor

1. Issue, if available:
redo of #1428

2. Description of changes:
refactor getting started guides to have a parent guide directory

3. How was this change tested?
netlify preview

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@geoffcline geoffcline self-assigned this Mar 1, 2022
@netlify
Copy link

netlify bot commented Mar 1, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 238df15

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621e955911443d00072ef93f

😎 Browse the preview: https://deploy-preview-1444--karpenter-docs-prod.netlify.app

@geoffcline
Copy link
Contributor Author

don't merge yet, doing a broken URL check on the netlify preview

@geoffcline
Copy link
Contributor Author

I used git mv instead of mv in hopes of making the diff clearer, no luck.

@geoffcline
Copy link
Contributor Author

ready 2 review

Copy link
Contributor

@spring1843 spring1843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellistarn
Copy link
Contributor

Looks like we have a rebase conflict again.

@geoffcline geoffcline closed this Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants