-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented pprof #1908
Implemented pprof #1908
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want the Profiling endpoint to be enabled by default? Or should we add a command line flag to explicitly enable Profiling similar to kube-controller-manager?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of small suggestions to the one doc file.
I'm not savvy to the tradeoffs of running this by default. I've read about security concerns, but we already expose a broad amount of metrics on :8080 and rely on Kubernetes networking to protect the pod. Perhaps there are some performance conerns? Seems like it might be okay according to rakyll@ |
@ellistarn and I spoke offline a bit more and it's probably worth enabling the debug endpoint via a flag or ENV when needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Issue, if available:
2. Description of changes:
😮😮😮😮😮
😮😮😮😮😮
😮😮😮😮😮
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.