Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented pprof #1908

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Implemented pprof #1908

merged 4 commits into from
Jun 20, 2022

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:
😮😮😮😮😮
😮😮😮😮😮
😮😮😮😮😮
karpenter-profile

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner June 8, 2022 21:55
@ellistarn ellistarn requested a review from njtran June 8, 2022 21:55
@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit cd5f75f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62acfd6a08ea4b00082a50b1

Copy link
Contributor

@dewjam dewjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want the Profiling endpoint to be enabled by default? Or should we add a command line flag to explicitly enable Profiling similar to kube-controller-manager?

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of small suggestions to the one doc file.

@ellistarn
Copy link
Contributor Author

ellistarn commented Jun 9, 2022

@dewjam

Do we want the Profiling endpoint to be enabled by default? Or should we add a command line flag to explicitly enable Profiling similar to kube-controller-manager?

I'm not savvy to the tradeoffs of running this by default. I've read about security concerns, but we already expose a broad amount of metrics on :8080 and rely on Kubernetes networking to protect the pod. Perhaps there are some performance conerns?

Seems like it might be okay according to rakyll@
https://stackoverflow.com/questions/64057727/is-it-ok-to-use-golang-pprof-on-production-without-effecting-performance

@dewjam
Copy link
Contributor

dewjam commented Jun 15, 2022

@ellistarn and I spoke offline a bit more and it's probably worth enabling the debug endpoint via a flag or ENV when needed.

Copy link
Contributor

@dewjam dewjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants