fix: Separate zone caching by subnet selectors #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
ellistarn
reviewed
Aug 1, 2022
ellistarn
reviewed
Aug 1, 2022
Co-authored-by: Ellis Tarn <ellistarn@gmail.com>
Thanks for the quick turnaround! Applied the recommendation. |
|
looks like |
3 tasks
Sorry for the bumbling around, fixed. Will keep an eye on any new silly compile errors. |
|
@bwagner5 would it be possible to get this into a new RC (or if there is a regular release coming up, that would work as well)? Thanks! |
|
We have snapshot builds, this includes this PR: public.ecr.aws/karpenter/controller:f4594705f9d20d3d1568fe5f989112dabbc51579 |
njtran
pushed a commit
to njtran/karpenter-provider-aws
that referenced
this pull request
Aug 9, 2022
* [aws]: Separate zone caching by subnet selectors * Update pkg/cloudprovider/aws/instancetypes.go Co-authored-by: Ellis Tarn <ellistarn@gmail.com> * Update pkg/cloudprovider/aws/instancetypes.go * fix import Co-authored-by: Ellis Tarn <ellistarn@gmail.com> Co-authored-by: Brandon Wagner <bmwagner10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2228
Description
The set of zones for instance types was using the same cache key irrespective of the subnet selector. As a result, if two provisioners had distinct subnetSelectors that matched subnets in different availability zones, the karpenter controller would only see one of them and be unable to schedule nodes on some of the subnets.
How was this change tested?
Manually tested by patching this change on top of the v0.13.2-release branch in our cluster.
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.