Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: terraform docs change #2618

Merged
merged 1 commit into from Oct 7, 2022

Conversation

SilentEntity
Copy link
Contributor

@SilentEntity SilentEntity commented Oct 6, 2022

Fixes #2613
Fixes #2617

Description
Docs were missing for terraform.

How was this change tested?

  • terraform init

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

terraform docs enhancement for v0.17.0

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SilentEntity SilentEntity requested a review from a team as a code owner October 6, 2022 18:50
@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit eb9956b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/633ff7e5142126000951e7f2
😎 Deploy Preview https://deploy-preview-2618--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SilentEntity SilentEntity changed the title terraform docs change docs:terraform docs change Oct 6, 2022
@SilentEntity SilentEntity changed the title docs:terraform docs change docs: terraform docs change Oct 6, 2022
ellistarn
ellistarn previously approved these changes Oct 6, 2022
@SilentEntity SilentEntity requested review from ellistarn and removed request for jonathan-innis October 7, 2022 06:35
@SilentEntity SilentEntity changed the title docs: terraform docs change docs/chore: terraform docs change and go vulnerability fix Oct 7, 2022
go.mod Outdated Show resolved Hide resolved
@SilentEntity SilentEntity changed the title docs/chore: terraform docs change and go vulnerability fix docs: terraform docs change Oct 7, 2022
@SilentEntity SilentEntity requested review from jonathan-innis and ellistarn and removed request for ellistarn and jonathan-innis October 7, 2022 09:47
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit a7d1756 into aws:main Oct 7, 2022
@SilentEntity SilentEntity deleted the docs-enhancement-v0.17.0 branch October 8, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.17 was not published to the helm chart Documentation
3 participants