fix: go mod linting errors and add dependabot for the test module #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
requested changes
Oct 7, 2022
| @@ -118,10 +118,6 @@ docgen: ## Generate docs | |||
| api-code-gen: ## Auto generate files based on AWS APIs response | |||
| $(WITH_GOFLAGS) ./hack/api-code-gen.sh | |||
|
|
|||
| release-gen: tidy download docgen ## Generate any materials which should be updated prior to release | |||
There was a problem hiding this comment.
This is part of the stable release workflow, so I don't think that we can delete this
There was a problem hiding this comment.
The observation is that release-gen is really just doing docgen at this point. There aren't any code changes happening in that workflow, as they would have had to happen prior to the release.
ellistarn
changed the title
ellistarn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
Head broken due to dependabot not being caught up to latest makefile changes.
How was this change tested?
Does this change impact docs?
Release Note
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.