Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add go.work and remove replace directive #2632

Merged
merged 1 commit into from Oct 10, 2022
Merged

chore: Add go.work and remove replace directive #2632

merged 1 commit into from Oct 10, 2022

Conversation

jonathan-innis
Copy link
Contributor

Fixes #

Description

Adds go.work in /test over replace directive. There are a couple reasons for this:

  1. This is the recommended way to reference local modules after 1.18
  2. This means that we can update our package dependencies go.mod and test/go.mod without them affecting each other (which has been a headache as of late)

How was this change tested?

  • make build
  • TEST_FILTER=Integration make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 9, 2022 06:58
@netlify
Copy link

netlify bot commented Oct 9, 2022 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit fe54c54
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/63447fb34dd8430009507c2e

@jonathan-innis jonathan-innis force-pushed the fix-replace-directive branch 2 times, most recently from e40d857 to 88432d9 Compare October 10, 2022 18:03
@bwagner5
Copy link
Contributor

Looks like you need to check in test/go.work.sum

@jonathan-innis jonathan-innis merged commit cc77459 into aws:main Oct 10, 2022
@jonathan-innis jonathan-innis deleted the fix-replace-directive branch October 10, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonathan-innis @bwagner5 @ellistarn