Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show changed files in verify #2642

Merged
merged 1 commit into from Oct 10, 2022
Merged

Conversation

bwagner5
Copy link
Contributor

Fixes #

Description
Show the changed files when running make verify and files have been changed during that process:

How was this change tested?

make verify
go mod tidy
go mod download
controller-gen \
		object:headerFile="hack/boilerplate.go.txt" \
		crd \
		paths="./pkg/..." \
		output:crd:artifacts:config=charts/karpenter/crds
hack/boilerplate.sh
golangci-lint run
New file modification detected in the Git working tree. Please check in before commit.
  - Makefile
  - test/go.work.sum

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner October 10, 2022 19:39
@netlify
Copy link

netlify bot commented Oct 10, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 257d8fe
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/634474ed36a53a0008e1845c

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn merged commit f2a49d4 into aws:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants