Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap action order to get a clean git commit message #2645

Merged
merged 1 commit into from Oct 11, 2022
Merged

fix: swap action order to get a clean git commit message #2645

merged 1 commit into from Oct 11, 2022

Conversation

spring1843
Copy link
Contributor

…files in the repo

Fixes #

Description
Changes the order of jobs such that at the time of releasing the binary there are no changes to the code base hence not showing "{commit-id}-dirty in the binary.

How was this change tested?

  • My fork

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@spring1843 spring1843 requested a review from a team as a code owner October 11, 2022 14:49
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8831404
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6345827e7c5f8b00086dd35f

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spring1843 spring1843 merged commit 02a4c28 into aws:main Oct 11, 2022
@spring1843 spring1843 deleted the rm/clean-release-commit branch October 11, 2022 15:04
@ellistarn
Copy link
Contributor

Nice thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants