-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Karpenter support for Windows docs #4074
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Fix broken link to cilium docs - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Specify that Windows supports GPU instances - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Specify importance of enabling Windows IPAM when running Windows nodes - Add Windows well known labels - Add Windows troubleshooting scenarios
9fb7d09
to
df60893
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Fix broken link to cilium docs - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Specify that Windows supports GPU instances - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Specify importance of enabling Windows IPAM when running Windows nodes - Add Windows well known labels - Add Windows troubleshooting scenarios updating bootstrap version
df60893
to
acea003
Compare
website/content/en/docs/getting-started/getting-started-with-karpenter/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level comment: Can you move all the changes that you made to docs/
to the preview/
directory?
acea003
to
249d3e6
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
249d3e6
to
eb8bfa6
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
eb8bfa6
to
08d33e8
Compare
website/content/en/preview/getting-started/getting-started-with-karpenter/_index.md
Outdated
Show resolved
Hide resolved
website/content/en/preview/getting-started/getting-started-with-karpenter/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few small comments.
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
08d33e8
to
65fcf2b
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
65fcf2b
to
27c2836
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
27c2836
to
9aab3b4
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
9aab3b4
to
447fd4a
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
447fd4a
to
c017f2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks @jonathan-innis, @rawahars, @sftim, @chrisnegus for the helpful docs feedback. Will be on standby if there are any further suggestions before the docs are merged. |
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
c017f2a
to
3750e22
Compare
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
3750e22
to
6d3da34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on opening up github issues to track some of the differences in feature parity for windows, and one nit
Various documentation changes including - Add statement specifying that userdata is not supported for Windows at the current time - Add EBS defaults for WS2019 and WS2022 - Add links to example configurations in provisioner and nodetemplate pages - Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022 - Specify that Karpenter supports Windows and Linux - Add example Windows provisioners and awsnodetemplates - Specify Windows2019 and Windows2022 are supported AMI families - Add Windows well known labels - Add Windows troubleshooting scenarios - Fix broken link to cilium docs
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
9f1dea9
to
3bbbd03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1131
Description
Karpenter will be adding Windows support in an upcoming change and this pull request contains documentation updates related to Karpenter Windows support.
How was this change tested?
Doc changes have been verified by checking the Netlify deploy preview 4074.
Does this change impact docs?
Release Note
No release notes required for this PR. Release notes regarding Windows support will be included in PR #3698 with the following text.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.