Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Karpenter support for Windows docs #4074

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

tzifudzi
Copy link
Contributor

@tzifudzi tzifudzi commented Jun 19, 2023

Fixes #1131

Description
Karpenter will be adding Windows support in an upcoming change and this pull request contains documentation updates related to Karpenter Windows support.

How was this change tested?

Doc changes have been verified by checking the Netlify deploy preview 4074.

Does this change impact docs?

  • Yes, PR includes docs updates

Release Note

No release notes required for this PR. Release notes regarding Windows support will be included in PR #3698 with the following text.

Add Windows support by introducing new Windows AMI Families.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 3bbbd03
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/649cda19c102b30008f18fa5
😎 Deploy Preview https://deploy-preview-4074--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 19, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Fix broken link to cilium docs
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Specify that Windows supports GPU instances
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Specify importance of enabling Windows IPAM when running Windows nodes
- Add Windows well known labels
- Add Windows troubleshooting scenarios
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 19, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Fix broken link to cilium docs
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Specify that Windows supports GPU instances
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Specify importance of enabling Windows IPAM when running Windows nodes
- Add Windows well known labels
- Add Windows troubleshooting scenarios
updating bootstrap version
@tzifudzi tzifudzi marked this pull request as ready for review June 19, 2023 19:14
@tzifudzi tzifudzi requested a review from a team as a code owner June 19, 2023 19:14
@tzifudzi tzifudzi requested a review from ellistarn June 19, 2023 19:14
examples/provisioner/windows.yaml Outdated Show resolved Hide resolved
examples/provisioner/windows.yaml Outdated Show resolved Hide resolved
website/content/en/docs/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/pod-density.md Outdated Show resolved Hide resolved
website/content/en/v0.28/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/v0.28/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/v0.28/troubleshooting.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level comment: Can you move all the changes that you made to docs/ to the preview/ directory?

examples/provisioner/windows.yaml Outdated Show resolved Hide resolved
website/content/en/docs/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/provisioners.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/docs/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/docs/troubleshooting.md Outdated Show resolved Hide resolved
website/content/en/v0.28/concepts/node-templates.md Outdated Show resolved Hide resolved
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 26, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 26, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 26, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
website/content/en/preview/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/pod-density.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/pod-density.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/pod-density.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/preview/faq.md Outdated Show resolved Hide resolved
website/content/en/preview/faq.md Outdated Show resolved Hide resolved
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few small comments.

website/content/en/preview/concepts/provisioners.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/scheduling.md Outdated Show resolved Hide resolved
website/content/en/preview/troubleshooting.md Outdated Show resolved Hide resolved
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 27, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 27, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 27, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 27, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 27, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
jonathan-innis
jonathan-innis previously approved these changes Jun 27, 2023
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tzifudzi
Copy link
Contributor Author

Thanks @jonathan-innis, @rawahars, @sftim, @chrisnegus for the helpful docs feedback. Will be on standby if there are any further suggestions before the docs are merged.

tzifudzi added a commit to tzifudzi/karpenter that referenced this pull request Jun 28, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
jonathan-innis pushed a commit to tzifudzi/karpenter that referenced this pull request Jun 28, 2023
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on opening up github issues to track some of the differences in feature parity for windows, and one nit

website/content/en/preview/concepts/node-templates.md Outdated Show resolved Hide resolved
website/content/en/preview/concepts/pod-density.md Outdated Show resolved Hide resolved
website/content/en/preview/faq.md Show resolved Hide resolved
tzifudzi and others added 3 commits June 28, 2023 18:10
Various documentation changes including
- Add statement specifying that userdata is not supported for Windows at the current time
- Add EBS defaults for WS2019 and WS2022
- Add links to example configurations in provisioner and nodetemplate pages
- Specify that containerd is the default runtime in Kubernetes 1.24+ for WS2019 and WS2022
- Specify that Karpenter supports Windows and Linux
- Add example Windows provisioners and awsnodetemplates
- Specify Windows2019 and Windows2022 are supported AMI families
- Add Windows well known labels
- Add Windows troubleshooting scenarios
- Fix broken link to cilium docs
Co-authored-by: Nick Tran <10810510+njtran@users.noreply.github.com>
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

@rawahars rawahars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathan-innis jonathan-innis enabled auto-merge (squash) June 29, 2023 16:40
@jonathan-innis jonathan-innis merged commit fa3a89a into aws:main Jun 29, 2023
14 checks passed
@tzifudzi tzifudzi deleted the docs/windows-support branch October 8, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows support
6 participants