Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add bottlerocket cloud-provider config #4121

Merged
merged 1 commit into from
Jun 23, 2023
Merged

chore: add bottlerocket cloud-provider config #4121

merged 1 commit into from
Jun 23, 2023

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jun 23, 2023 •
edited

Fixes #4118

Description

  • Adds Bottlerocket settings.kubernetes.cloud-provider config for toml user-data config.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner June 23, 2023 18:51
@bwagner5 bwagner5 requested a review from njtran June 23, 2023 18:51
@netlify
Copy link

netlify bot commented Jun 23, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d277bfd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6495f23f029c8a0008a4c8c7

jonathan-innis
jonathan-innis approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bwagner5 bwagner5 merged commit 158a8c8 into aws:main Jun 23, 2023
13 checks passed
@bwagner5 bwagner5 deleted the br-cp branch June 23, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran Awaiting requested review from njtran njtran is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support to pass cloud-provider via userData to Bottlerocket nodes
2 participants
@bwagner5 @jonathan-innis