test: Update prop policy for deletion and propagate discovery label to pods #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
force-pushed
the
fix-consolidation-flakiness-e2e
branch
from
92dcc70
to
f0983de
Compare
|
Snapshot successfully published to |
jonathan-innis
force-pushed
the
fix-consolidation-flakiness-e2e
branch
from
f0983de
to
cb6e4a9
Compare
jonathan-innis
force-pushed
the
fix-consolidation-flakiness-e2e
branch
from
cb6e4a9
to
79eb59e
Compare
njtran
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
ForegroundDeletionfor allExpectDeletedoperations that take place during E2E testingkarpenter-corechange that adds thetesting.karpenter.shdiscovery label onto pods that are deployed by deployments: test: Propagate discovery label to pods owned by deployment kubernetes-sigs/karpenter#384How was this change tested?
/karpenter snapshotDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.