Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix node apiVersion in annotation example #4160

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jun 29, 2023

Fixes #4144

Description

  • The Node annotation example for deprovisioning was erroneously set to karpenter.sh/v1alpha5 when it should have been set to v1 from the Kubernetes core/v1 api package.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • [] Yes, issue opened: #
  • [] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner June 29, 2023 00:41
@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit c6a95f7
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/649cd32197953f000816a530
😎 Deploy Preview https://deploy-preview-4160--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis enabled auto-merge (squash) June 29, 2023 00:41
@jonathan-innis jonathan-innis merged commit 86ed398 into aws:main Jun 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Object Type in Docs on Disable Node Consolidation
2 participants