Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: publish instanceType, capacityType, availabilityZone in a k8s event when we receive a IsUnfulfillableCapacity error while trying to create fleet " #4212

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jul 6, 2023

Reverts #3999

Seeing errors from publishing events without involvedObject in the event spec

2023-07-06T07:27:19.253Z        ERROR   controller      Could not construct reference to: '<nil>' due to: 'can't reference a nil object'. Will not report event: 'Warning' 'UnavailableOffering' 'UnavailableOffering for {"instanceType": "c6i.2x
large", "availabilityZone": "us-west-2a", "capacityType": "spot"}'

… a k8s event when we receive a IsUnfulfillableCapacity error while trying to create fleet (#3999)"

This reverts commit 82f68a5.
@jonathan-innis jonathan-innis requested a review from a team as a code owner July 6, 2023 07:38
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3d76b98
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64a66f633ec3770008e3808e

@jonathan-innis jonathan-innis enabled auto-merge (squash) July 6, 2023 07:52
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-3d76b98d70dc3e2080199880ac5ecc5121dcf55f. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathan-innis jonathan-innis merged commit 7752b81 into main Jul 6, 2023
23 checks passed
@jonathan-innis jonathan-innis deleted the revert-3999-feat-add-ice-event-for-instance-type-az branch July 6, 2023 12:42
@bwagner5 bwagner5 mentioned this pull request Aug 15, 2023
tasdikrahman added a commit to tasdikrahman/karpenter that referenced this pull request Nov 14, 2023
…yZone in a k8s event when we receive a IsUnfulfillableCapacity error while trying to create fleet " (aws#4212)"

This reverts commit 7752b81.
tasdikrahman added a commit to tasdikrahman/karpenter that referenced this pull request Nov 15, 2023
…yZone in a k8s event when we receive a IsUnfulfillableCapacity error while trying to create fleet " (aws#4212)"

This reverts commit 7752b81.
tasdikrahman added a commit to tasdikrahman/karpenter that referenced this pull request Mar 5, 2024
…yZone in a k8s event when we receive a IsUnfulfillableCapacity error while trying to create fleet " (aws#4212)"

This reverts commit 7752b81.
johngmyers added a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Merge in DEL/karpenter-fork from upgrade-29-0 to main

* commit 'c6dd8b2cc1b0f5267a27c2b89380381e9a4d39c6': (95 commits)
  update to v0.29.0 karpenter-core (aws#4218)
  update karpenter-core (aws#4215)
  docs: Add karpenter working group call link to readme (aws#4214)
  Revert "feat: publish instanceType, capacityType, availabilityZone in a k8s event when we receive a IsUnfulfillableCapacity error while trying to create fleet " (aws#4212)
  test: Add more regions for e2etests (aws#4204)
  docs: Fix v0.28.0 version compatibility mention in the docs (aws#4203)
  chore: Update data from AWS APIs (aws#4191)
  chore(deps): bump github.com/onsi/ginkgo/v2 from 2.9.7 to 2.11.0 (aws#4184)
  chore(deps): bump github.com/aws/aws-sdk-go from 1.44.273 to 1.44.294 (aws#4185)
  chore(deps): bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (aws#4183)
  chore(deps): bump golang.org/x/sync from 0.2.0 to 0.3.0 (aws#4182)
  docs: Fix guidance on ALB and `securityGroupSelector` (aws#4181)
  docs: Remove tag restriction scoping on policy (aws#4180)
  docs: Add new DaemonSet FAQ for new DaemonSets deployed after Nodes exist (aws#4161)
  chore: Remove tekton directories and references (aws#4179)
  test: e2e prometheus endpoint metrics scraping (aws#4178)
  chore: Update stalebot labels to add back `roadmap` (aws#4177)
  test: Add check for snapshot release run (aws#4175)
  fix: only warn for ssm query errors (aws#4128)
  test: Add `sts:AssumeRole` for Root in IAM (aws#4172)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants