Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable china price gen #4763

Merged
merged 11 commits into from Oct 9, 2023
Merged

ci: disable china price gen #4763

merged 11 commits into from Oct 9, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 6, 2023

Fixes #N/A

Description
Separates out US and China price generation. This enables temporarily disabling china price gen.

How was this change tested?
make codegen

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner October 6, 2023 17:06
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 87a176a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6524745758b65a000842f70d

pkg/providers/pricing/pricing.go Outdated Show resolved Hide resolved
pkg/providers/pricing/pricing.go Outdated Show resolved Hide resolved
pkg/providers/pricing/pricing.go Outdated Show resolved Hide resolved
hack/codegen.sh Outdated Show resolved Hide resolved
@jmdeal jmdeal force-pushed the disable-cn-docgen branch 5 times, most recently from 5de7d52 to 44d6b00 Compare October 6, 2023 22:53
hack/code/prices_gen.go Outdated Show resolved Hide resolved
hack/code/prices_gen.go Outdated Show resolved Hide resolved
pkg/providers/pricing/zz_generated.pricing_aws_cn.go Outdated Show resolved Hide resolved
pkg/providers/pricing/zz_generated.pricing_aws_us_gov.go Outdated Show resolved Hide resolved
pkg/providers/pricing/zz_generated.pricing_aws.go Outdated Show resolved Hide resolved
pkg/providers/pricing/pricing.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) October 9, 2023 21:45
@jmdeal jmdeal merged commit 0ef00ab into aws:main Oct 9, 2023
11 checks passed
@jmdeal jmdeal deleted the disable-cn-docgen branch October 16, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants