New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: disable china price gen #4763
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jmdeal
force-pushed
the
disable-cn-docgen
branch
from
October 6, 2023 17:10
a47cf71
to
2758afa
Compare
jmdeal
force-pushed
the
disable-cn-docgen
branch
5 times, most recently
from
October 6, 2023 22:53
5de7d52
to
44d6b00
Compare
Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
jmdeal
force-pushed
the
disable-cn-docgen
branch
from
October 9, 2023 18:33
f18a772
to
b9891cc
Compare
jmdeal
force-pushed
the
disable-cn-docgen
branch
from
October 9, 2023 20:49
b9891cc
to
6905671
Compare
jonathan-innis
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Separates out US and China price generation. This enables temporarily disabling china price gen.
How was this change tested?
make codegen
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.