Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove c7a instancetype for windows test #4770

Merged
merged 1 commit into from
Oct 6, 2023
Merged

test: Remove c7a instancetype for windows test #4770

merged 1 commit into from
Oct 6, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Oct 6, 2023

Fixes #N/A

Description

  • Remove c7a instance type

How was this change tested?

  • /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner October 6, 2023 20:52
engedaam
engedaam commented Oct 6, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1fb3b7e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/652074ff4bc4090008f5a44c

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-7221f37f6cf0d613bc0f898aff12a0c6e0d56752.

@engedaam engedaam force-pushed the remove-instancetype-windows-ami branch from 7221f37 to 1fb3b7e Compare October 6, 2023 20:58
jonathan-innis
jonathan-innis approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam enabled auto-merge (squash) October 6, 2023 21:05
@engedaam engedaam merged commit 7208b2e into aws:main Oct 6, 2023
12 checks passed
@engedaam engedaam deleted the remove-instancetype-windows-ami branch October 9, 2023 17:03
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
@engedaam @johngmyers
test: Remove c7a instancetype for windows test (aws#4770)
bd9924b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@engedaam @jonathan-innis