Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure that instance profile creation and assignment is idempotent #4798

Merged

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This PR ensures that we don't fail if the instance profile creation fails because the instance profile already exists

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 11, 2023 18:24
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 98d65ff
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6526f05bd68b2e0008e4f249

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-efbc0716b9055978e3161625d9a3bf49b366b177.

@jonathan-innis jonathan-innis force-pushed the idempotent-instance-profile-create branch from efbc071 to 98d65ff Compare October 11, 2023 18:58
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-98d65ffa51cc4b22816fbbd0bb4570b4d38a1542.

@jonathan-innis jonathan-innis enabled auto-merge (squash) October 11, 2023 19:06
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit a45c1fe into aws:main Oct 11, 2023
16 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants