Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add env vars for e2e tests #4815

Merged
merged 2 commits into from Oct 13, 2023
Merged

ci: add env vars for e2e tests #4815

merged 2 commits into from Oct 13, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 12, 2023

Fixes #N/A

Description
This PR adds CLUSTER_NAME and INTERRUPTION_QUEUE_NAME as environment variables for the e2e test suite. This is required for #4789 as it removes reliance on karpenter-global-settings to get these values.

How was this change tested?
N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner October 12, 2023 20:44
@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 63011cd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65289000205b510008d216f7

@jmdeal jmdeal force-pushed the e2e-env-update branch 2 times, most recently from 6c4c321 to b13a04e Compare October 12, 2023 23:43
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit be86a6f into aws:main Oct 13, 2023
12 checks passed
@jmdeal jmdeal deleted the e2e-env-update branch October 16, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants