Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ensure release can't be dirty #4824

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 13, 2023

Fixes #4807

Description
This PR ensures that a release can not happen with a dirty commit.

How was this change tested?
Manual test w/ echo

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner October 13, 2023 00:41
@jmdeal jmdeal requested a review from bwagner5 October 13, 2023 00:41
@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 23badaa
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/652892f107fb940008fd7d02

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 04c5306 into aws:main Oct 13, 2023
12 checks passed
@jmdeal jmdeal deleted the no-dirty-releases branch October 16, 2023 21:00
johngmyers pushed a commit to johngmyers/karpenter that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karpenter images running dirty commit
2 participants