Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stop firing conformance testing Notifications #4927

Merged
merged 1 commit into from Oct 25, 2023
Merged

fix: Stop firing conformance testing Notifications #4927

merged 1 commit into from Oct 25, 2023

Conversation

engedaam
Copy link
Contributor

Fixes #4845

Description

  • Conformance tests should not be triggering slack messages for all suites. Stop upgrade suite from firing messages

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner October 25, 2023 20:23
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 15517d2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6539793c0e5cdb0009f19853

@engedaam engedaam force-pushed the conformance-upgrade-suite-slack branch from 2f31420 to 15517d2 Compare October 25, 2023 20:23
jonathan-innis
jonathan-innis approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 6d4cd28 into aws:main Oct 25, 2023
12 checks passed
@engedaam engedaam deleted the conformance-upgrade-suite-slack branch October 25, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Conformance Testing from firing Notifications to Slack
2 participants
@engedaam @jonathan-innis