Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix some scale test bugs #4955

Merged
merged 1 commit into from Oct 30, 2023
Merged

test: fix some scale test bugs #4955

merged 1 commit into from Oct 30, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Oct 30, 2023

Fixes #N/A

Description

How was this change tested?
Locally

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner October 30, 2023 01:20
@njtran njtran requested a review from engedaam October 30, 2023 01:20
@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 49988b2
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/653f04fad6514c0008213b64

jonathan-innis
jonathan-innis approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran enabled auto-merge (squash) October 30, 2023 01:24
@njtran njtran merged commit 5d648a1 into aws:main Oct 30, 2023
12 checks passed
@njtran njtran deleted the testFixScale branch December 26, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@njtran @jonathan-innis