Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve error message for deleting EC2NodeClass #5656

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Feb 13, 2024

Fixes #5656

Description

This updates our error that we send back to users when EC2NodeClasses that are in a terminating state that we are treating as NotFound

How was this change tested?

make presubmit
make apply

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 5351e3f
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65cbc3ade81c04000923318d

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7891779882

Details

  • -12 of 13 (7.69%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 82.497%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cloudprovider/cloudprovider.go 1 13 7.69%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
pkg/cloudprovider/cloudprovider.go 2 72.35%
Totals Coverage Status
Change from base Build 7889953331: -0.2%
Covered Lines: 5015
Relevant Lines: 6079

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit b2e3bad into aws:main Feb 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants