Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin to the latest patch version of 1.25.x in toolchain #5672

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This pins to the latest version of the v1.25.x version of etcd and the apiserver to fix some CEL problems that we were seeing in the 1.25 version and not in newer versions. This pins in the same way that kubernetes-sigs/karpenter pins

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 854b5ef
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65ceb43ff0923200081c62c0

@jonathan-innis jonathan-innis enabled auto-merge (squash) February 16, 2024 01:07
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jigisha620 jigisha620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7924481481

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 82.497%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/ami.go 1 90.32%
Totals Coverage Status
Change from base Build 7923912915: -0.02%
Covered Lines: 5015
Relevant Lines: 6079

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 949decb into aws:main Feb 16, 2024
17 checks passed
jigisha620 pushed a commit to jigisha620/karpenter-provider-aws that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants