Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve Upgrade Guide and Troubleshooting Guide for DNS Policy Change #5818

Merged
merged 2 commits into from Mar 11, 2024

Conversation

jonathan-innis
Copy link
Contributor

Fixes #5817

Description

Add documentation in the upgrade guide and troubleshooting guide that clarifies the DNS policy change that was made in v0.34.x and clarifies how to resolve the issue if you run into it.

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner March 10, 2024 22:18
Copy link

netlify bot commented Mar 10, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 60a371c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65ee320cd2605e0008d89b00
😎 Deploy Preview https://deploy-preview-5818--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis enabled auto-merge (squash) March 10, 2024 22:19
@jonathan-innis jonathan-innis changed the title docs: Dns policy docs docs: Improve Upgrade Guide and Troubleshooting Guide for DNS Policy Change Mar 10, 2024
@coveralls
Copy link

coveralls commented Mar 10, 2024

Pull Request Test Coverage Report for Build 8225154376

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 82.727%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 94.56%
Totals Coverage Status
Change from base Build 8218002295: -0.03%
Covered Lines: 5302
Relevant Lines: 6409

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit b112bc2 into aws:main Mar 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart change in dnsPolicy might be breaking for AWS Fargate users
3 participants