fix: correct AMI ordering function #6164
Merged
+60
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
Pull Request Test Coverage Report for Build 8990509806Details
💛 - Coveralls |
jonathan-innis
pushed a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
May 13, 2024
jonathan-innis
pushed a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
May 13, 2024
jonathan-innis
pushed a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
May 13, 2024
jonathan-innis
pushed a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
May 13, 2024
jonathan-innis
pushed a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
May 13, 2024
jonathan-innis
pushed a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
May 13, 2024
jonathan-innis
pushed a commit
to jonathan-innis/karpenter-provider-aws
that referenced
this pull request
May 13, 2024
jonathan-innis
pushed a commit
that referenced
this pull request
May 15, 2024
jonathan-innis
pushed a commit
that referenced
this pull request
May 15, 2024
jonathan-innis
pushed a commit
that referenced
this pull request
May 15, 2024
jonathan-innis
pushed a commit
that referenced
this pull request
May 15, 2024
jonathan-innis
pushed a commit
that referenced
this pull request
May 15, 2024
jonathan-innis
pushed a commit
that referenced
this pull request
May 15, 2024
johngmyers
pushed a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Fixes a bug with the AMI ordering logic. This was only reached if Karpenter was trying to order AMIs that had both the same creation timestamp and the same name.
How was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.