Enforce error checking in CI #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 9efe10b 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62191df0309e1e0007c0f99e 😎 Browse the preview: https://deploy-preview-1417--karpenter-docs-prod.netlify.app |
…ce-err-checking
ellistarn
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
Enables a check that makes sure all errors are checked. This is good idea specially because we are already checking all errors except only in one test which this PR fixes.
There is really no good reason to leave errors unchecked. Beginners to Go are often surprised by how much error handling they have to do. In my perspective this is one of the beauties of Go. It makes the programmer think and react everywhere things can go wrong and we know at scale things that can go wrong will go wrong. Handling all errors therefore is part of what it takes to produce high quality and reliable software.
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.