New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AL2 UserData Merge Support #1861
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -243,75 +243,10 @@ spec: | |||
|
|||
### UserData | |||
|
|||
In order to specify custom user data, you must include it within the AWSNodeTemplate resource. You can then reference the AWSNodeTemplate resource through `spec.providerRef` in your provisioner. | |||
You can control the UserData that needs to be applied to your worker nodes via the `spec.providerRef` field in your provisioner. | |||
Review the [Custom UserData documentation](../user-data/) to learn the necessary steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we frame this page as a single "launch templates" story that talks about everything? To start, we can just include the content you have and elaborate from there.
Review the [Custom UserData documentation](../user-data/) to learn the necessary steps. | |
Review [Custom Launch Templates](../launch-templates/) to learn the necessary steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I called it Custom UserData
to distinguish it from this doc https://karpenter.sh/v0.10.1/aws/launch-templates/ that's titled Launch Templates and Custom Images
.
Not sure what terminology would fit better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's collapse it later.
``` | ||
spec: | ||
provider: | ||
amiFamily: Bottlerocket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From our discussion, I thought provider and providerRef was an OR semantic. The user would need to specify these in in the AWSNodeTemplate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a much larger change to make. I can work on it in a separate PR - do you think we should disable this feature until that's complete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah probably. Only because it will break early adopters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few minor comments.
Co-authored-by: Ellis Tarn <ellistarn@gmail.com>
1. Issue, if available:
#885
2. Description of changes:
Customer Managed
->Karpenter Managed
.3. How was this change tested?
I tested this locally by creating the necessary resources and scaling the inflate pods. Also verified that the docs links were correct.
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.