fix: only warn for ssm query errors #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
|
Would you be willing to add a functional unit test for this new scenario where the SSM alias isn't available but some other alias is available within the |
Went ahead and added some functional tests around this functionality |
|
Snapshot successfully published to |
njtran
reviewed
Jun 29, 2023
njtran
previously approved these changes
Jun 29, 2023
njtran
approved these changes
Jun 29, 2023
|
Sorry for missing notification on it, thanks a lot for helping went this ahead! |
johngmyers
added a commit
to johngmyers/karpenter
that referenced
this pull request
May 31, 2024
Merge in DEL/karpenter-fork from upgrade-29-0 to main * commit 'c6dd8b2cc1b0f5267a27c2b89380381e9a4d39c6': (95 commits) update to v0.29.0 karpenter-core (aws#4218) update karpenter-core (aws#4215) docs: Add karpenter working group call link to readme (aws#4214) Revert "feat: publish instanceType, capacityType, availabilityZone in a k8s event when we receive a IsUnfulfillableCapacity error while trying to create fleet " (aws#4212) test: Add more regions for e2etests (aws#4204) docs: Fix v0.28.0 version compatibility mention in the docs (aws#4203) chore: Update data from AWS APIs (aws#4191) chore(deps): bump github.com/onsi/ginkgo/v2 from 2.9.7 to 2.11.0 (aws#4184) chore(deps): bump github.com/aws/aws-sdk-go from 1.44.273 to 1.44.294 (aws#4185) chore(deps): bump github.com/onsi/gomega from 1.27.7 to 1.27.8 (aws#4183) chore(deps): bump golang.org/x/sync from 0.2.0 to 0.3.0 (aws#4182) docs: Fix guidance on ALB and `securityGroupSelector` (aws#4181) docs: Remove tag restriction scoping on policy (aws#4180) docs: Add new DaemonSet FAQ for new DaemonSets deployed after Nodes exist (aws#4161) chore: Remove tekton directories and references (aws#4179) test: e2e prometheus endpoint metrics scraping (aws#4178) chore: Update stalebot labels to add back `roadmap` (aws#4177) test: Add check for snapshot release run (aws#4175) fix: only warn for ssm query errors (aws#4128) test: Add `sts:AssumeRole` for Root in IAM (aws#4172) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some region without specific AMI such as
cn-northwest-1, launching would fail with errors like:This error should be ignored since we do not need this kind of AMIs.
How was this change tested?
Tested with AWS
cn-northwest-1Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.