Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogusata/hot fix file name starts with dot and slash it doesnt have actions #60

Conversation

dogusata
Copy link
Collaborator

Problem

  • When the given path for a file starts with ./ it doesn't show the file actions and not triggering the file click.
  • When there is a long text inside a followup, it should fit until the line ends instead of cropping at fixed 40 chars.

Solution

  • File path actions and onFileClick events are fixed with original file path check instead of the modified one.
  • Added followup inner span text overflow structure instead of cropping the text programmatically and added the check for width overflowing to show the tooltip.

This PR also includes:

  • File list updates on the example app
  • Z-Index fix for letting the Overlay items show properly

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dogusata dogusata requested a review from a team as a code owner June 19, 2024 12:45
@dogusata dogusata merged commit a2e0311 into main Jun 19, 2024
1 check passed
@ege0zcan ege0zcan deleted the dogusata/hot-fix-file-name-starts-with-dot-and-slash-it-doesnt-have-actions branch June 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant