Skip to content

Commit

Permalink
Remove \r\n from logging statements. (#470)
Browse files Browse the repository at this point in the history
  • Loading branch information
paulbartell committed Feb 10, 2023
1 parent e42ac54 commit 45342aa
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions source/ota.c
Original file line number Diff line number Diff line change
Expand Up @@ -3234,7 +3234,7 @@ static void resetEventQueue( void )

while( otaAgent.pOtaInterface->os.event.recv( NULL, &eventMsg, 0 ) == OtaOsSuccess )
{
LogWarn( ( "Event(%d) is dropped.\r\n", eventMsg.eventId ) );
LogWarn( ( "Event(%d) is dropped.", eventMsg.eventId ) );

/* Call handleUnexpectedEvents to notify user to release resources if necessary. */
handleUnexpectedEvents( &eventMsg );
Expand Down Expand Up @@ -3312,7 +3312,7 @@ OtaErr_t OTA_Init( const OtaAppBuffer_t * pOtaBuffer,

if( pThingName == NULL )
{
LogError( ( "Error: Thing name is NULL.\r\n" ) );
LogError( ( "Error: Thing name is NULL." ) );
}
else
{
Expand All @@ -3329,7 +3329,7 @@ OtaErr_t OTA_Init( const OtaAppBuffer_t * pOtaBuffer,
}
else
{
LogError( ( "Error: Thing name is too long.\r\n" ) );
LogError( ( "Error: Thing name is too long." ) );
}
}

Expand Down
8 changes: 4 additions & 4 deletions source/portable/os/ota_os_freertos.c
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ static void selfTestTimerCallback( TimerHandle_t T )
{
( void ) T;

LogDebug( ( "Self-test expired within %ums\r\n",
LogDebug( ( "Self-test expired within %ums",
otaconfigSELF_TEST_RESPONSE_WAIT_MS ) );

if( otaTimerCallbackPtr != NULL )
Expand All @@ -185,15 +185,15 @@ static void selfTestTimerCallback( TimerHandle_t T )
}
else
{
LogWarn( ( "Self-test timer event unhandled.\r\n" ) );
LogWarn( ( "Self-test timer event unhandled." ) );
}
}

static void requestTimerCallback( TimerHandle_t T )
{
( void ) T;

LogDebug( ( "Request timer expired in %ums \r\n",
LogDebug( ( "Request timer expired in %ums",
otaconfigFILE_REQUEST_WAIT_MS ) );

if( otaTimerCallbackPtr != NULL )
Expand All @@ -202,7 +202,7 @@ static void requestTimerCallback( TimerHandle_t T )
}
else
{
LogWarn( ( "Request timer event unhandled.\r\n" ) );
LogWarn( ( "Request timer event unhandled." ) );
}
}

Expand Down
8 changes: 4 additions & 4 deletions source/portable/os/ota_os_posix.c
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ static void selfTestTimerCallback( union sigval arg )
{
( void ) arg;

LogDebug( ( "Self-test expired within %ums\r\n",
LogDebug( ( "Self-test expired within %ums",
otaconfigSELF_TEST_RESPONSE_WAIT_MS ) );

if( otaTimerCallbackPtr != NULL )
Expand All @@ -294,15 +294,15 @@ static void selfTestTimerCallback( union sigval arg )
}
else
{
LogWarn( ( "Self-test timer event unhandled.\r\n" ) );
LogWarn( ( "Self-test timer event unhandled." ) );
}
}

static void requestTimerCallback( union sigval arg )
{
( void ) arg;

LogDebug( ( "Request timer expired in %ums \r\n",
LogDebug( ( "Request timer expired in %ums",
otaconfigFILE_REQUEST_WAIT_MS ) );

if( otaTimerCallbackPtr != NULL )
Expand All @@ -311,7 +311,7 @@ static void requestTimerCallback( union sigval arg )
}
else
{
LogWarn( ( "Request timer event unhandled.\r\n" ) );
LogWarn( ( "Request timer event unhandled." ) );
}
}

Expand Down

0 comments on commit 45342aa

Please sign in to comment.