-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify user that an OTA download is going to start. #445
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for adding this new notification type ?
Can we pass any useful information along with the event type ?
Can we add unit tests for the change?
In #214 description, user needs to know what's the job handling in OTA library.
I think we can provide a job doc for user to know the job ID. I'll add it and try to add unit tests. |
Notify user that an OTA download is going to start.
Description
Callback to user when a new OTA job is received.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.