feat(s2n-quic-rustls): parse multiple der certs #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Apr 8, 2024
common/s2n-codec/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "s2n-codec" | |||
| version = "0.35.1" | |||
| version = "0.36.0" | |||
There was a problem hiding this comment.
I'd prefer to have a specific commit to bump, just so we can point the tag at that commit
Comment on lines
86
to
92
| let certs = self | ||
| .iter() | ||
| .map(|cert| der::into_certificate(cert.to_vec())) | ||
| .collect::<Result<Vec<_>, _>>()? | ||
| .into_iter() | ||
| .flatten() | ||
| .collect(); |
There was a problem hiding this comment.
I'm wondering if this code would be clearer with a more imperative approach?
Suggested change
| let certs = self | |
| .iter() | |
| .map(|cert| der::into_certificate(cert.to_vec())) | |
| .collect::<Result<Vec<_>, _>>()? | |
| .into_iter() | |
| .flatten() | |
| .collect(); | |
| let mut certs = vec![]; | |
| for der in self { | |
| let der = der.into_certificate()?; | |
| certs.extend(der.0); | |
| } |
There was a problem hiding this comment.
yeah, much clearer!
camshaft
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds support in rustls for parsing multiple der formatted certificates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.