build(bindings): use cmake when building with pq feature #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
rust-pq
branch
7 times, most recently
from
a03ddf8
to
a2fb625
Compare
lrstewart
approved these changes
Apr 28, 2022
Comment on lines
+35
to
+36
| # Pin to this version until s2n-tls supports OpenSSL 3.0 | ||
| # Build the vendored version to make it easy to test in dev |
There was a problem hiding this comment.
Why do we need to pin to a version if the actual openssl version is automatically discovered?
There was a problem hiding this comment.
when you use the vendored feature flag it pulls the source and builds it locally for you. after 0.9.68 the pull openssl 3.0 instead of 1.1.1.
There was a problem hiding this comment.
but we only do this in dev to make it so you don't have to run our codebuild install scripts
dougch
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We currently don't have support for building the rust bindings when vendored with PQ support. The PQ crypto build logic is quite complicated so it hasn't been ported to the
build.rs.Instead of porting the logic, this PR builds s2n-tls with cmake when the PQ feature is enabled. This is a lot less work but does require that cmake is installed on the build machine.
Testing:
I've added
cargo test --features pqto ourgenerate.shscript to catch any issues.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.