Allow static and shared libs to be mixed (take 2) #3484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously reviewed here: #3467
That was merged to main, but then it broke many other tests, so the commit was reverted.
This PR is exactly the same thing, except LD_LIBRARY_PATH is no longer being tampered with.
I've run the s2nOmnibus tests on this branch, and they're all passing.
Resolved issues:
This is part of a fix for an issue from another repo: aws4embeddedlinux/meta-aws#191
Description of changes:
Currently, users cannot build a shared lib that uses a static libs2n.a, and they cannot build a static lib that uses a shared libs2n.so.
With this change, a library can use either static libs2n.a or shared libs2n.so. If both are static and shared libs2n are installed, BUILD_SHARED_LIBS serves as a tie-breaker.
Testing:
Added new unit test.
Did local testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.