Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ctest always print output on failure #4052

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

lrstewart
Copy link
Contributor

Resolved issues:

Address's @jmayclin's comment: #4046 (comment)

Description of changes:

Adds CTEST_OUTPUT_ON_FAILURE=1 to all unit test runs. This will be super helpful since we always want output on failure, but constantly forget to add the option since it's not on by default.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jun 13, 2023
Comment on lines -109 to +110
echo "Running... ctest --no-tests=error --output-on-failure --verbose -R ^integrationv2_${test}$"
ctest --no-tests=error --output-on-failure --verbose -R ^integrationv2_${test}$
echo "Running... ctest --no-tests=error --verbose -R ^integrationv2_${test}$"
ctest --no-tests=error --verbose -R ^integrationv2_${test}$
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My CMake build change wouldn't actually affect this call to ctest, since I only modified the environment for unit tests. But this call already has "--verbose", which outputs on failure AND on success, so "--output-on-failure" is unnecessary anyway.

@lrstewart lrstewart mentioned this pull request Jun 16, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant