kTLS: implement sendmsg #4147
Merged
kTLS: implement sendmsg #4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
ak-ktls1_sendmsg
branch
from
90e8bdd
to
e4f2cb6
Compare
toidiu
force-pushed
the
ak-ktls1_sendmsg
branch
from
e4f2cb6
to
9637ba3
Compare
This was referenced Aug 15, 2023
lrstewart
reviewed
Aug 16, 2023
lrstewart
reviewed
Aug 16, 2023
toidiu
force-pushed
the
ak-ktls1_sendmsg
branch
4 times, most recently
from
49f2867
to
ab61b19
Compare
toidiu
force-pushed
the
ak-ktls1_sendmsg
branch
from
ab61b19
to
a2a0909
Compare
toidiu
force-pushed
the
ak-ktls1_sendmsg
branch
2 times, most recently
from
23c3f3a
to
60e6dd2
Compare
lrstewart
reviewed
Aug 17, 2023
tls/s2n_ktls_io.c
Outdated
Comment on lines
186
to
189
|
|
||
| RESULT_ENSURE(msg_iov->iov_base, S2N_ERR_INVALID_ARGUMENT); |
There was a problem hiding this comment.
Why is this check necessary?
There was a problem hiding this comment.
We are creating a msghdr using iovec and there is an assumption that iovec is not malformed. This check confirms that assumption. If iovec is NULL then msghdr is also malformed.
There was a problem hiding this comment.
Would the iovec be considered malformed if iov_base is NULL and iov_len is 0?
There was a problem hiding this comment.
ill check and ban both NULL and 0.. that seems safer for now and we can support sending 0 later if we need
changed my mind. I'll allow both since we should be able to send 0 data and thats valid.
toidiu
force-pushed
the
ak-ktls1_sendmsg
branch
2 times, most recently
from
1f3fa42
to
5dab077
Compare
lrstewart
reviewed
Aug 18, 2023
lrstewart
approved these changes
Aug 21, 2023
maddeleine
reviewed
Aug 21, 2023
maddeleine
approved these changes
Aug 21, 2023
toidiu
force-pushed
the
ak-ktls1_sendmsg
branch
from
327c514
to
23e1a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds an implementation for s2n_ktls_sendmsg. This essentially takes some data and some record_type and calls the
sendmsgsyscall. It creates amsghdrand configures the control data on it. Finally it is also doing some error handling (mainly IO blocked error).Call-outs:
Testing:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.