bindings: ensure CFLAGS includes come after libcrypto includes #4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
approved these changes
Dec 21, 2023
goatgoose
reviewed
Dec 21, 2023
goatgoose
approved these changes
Dec 21, 2023
lrstewart
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
cccrate used for compiling the rust bindings will automatically add all flags and includes from theCFLAGSenvironment variable in the build command, ahead of any other includes that are explicitly specified. This can result in conflicts if the includes inCFLAGSshould come after the libcrypto includes. This change prepends the libcrypto includes to theCFLAGSenv variable to ensure they are considered first when compiling.Call-outs
The same things is true for C++ flags (
CXXFLAGS), do we need to account for that as well?Testing:
Tested locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.