Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pedantic memory leak in handshake test #4463

Merged
merged 5 commits into from
Mar 20, 2024
Merged

fix: pedantic memory leak in handshake test #4463

merged 5 commits into from
Mar 20, 2024

Commits on Mar 20, 2024

  1. fix: pedantic memory leak in handshake test 

    We run valgrind with "pedantic" settings, which requires that memory in
child processes is explicitly freed before the memory goes out of scope.
This is commonly an issue when defer cleanup is used, because defer
cleanup statements are not invoked when the "exit" system call is used.
    @jmayclin
    jmayclin committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    35ba7c4 View commit details
    Browse the repository at this point in the history

  2. assert free success

    @jmayclin
    jmayclin committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    bd830c1 View commit details
    Browse the repository at this point in the history

  3. address pr feedback 

    - use nested scope rather than explicit frees
    @jmayclin
    jmayclin committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    45bd8d7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-pedantic-leak

    @jmayclin
    jmayclin authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2e23a5b View commit details
    Browse the repository at this point in the history

  5. Update tests/unit/s2n_handshake_test.c 

    Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
    @jmayclin @goatgoose
    jmayclin and goatgoose authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    5f43929 View commit details
    Browse the repository at this point in the history