Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building for AL2 #4679

Merged
merged 9 commits into from
Aug 16, 2024
Merged

fix: building for AL2 #4679

merged 9 commits into from
Aug 16, 2024

Conversation

lucykorea414
Copy link
Contributor

replaced 'cmake' to 'cmake3' in building instructions for AL2

Resolved issues:

N/A

Description of changes:

replaced 'cmake' to 'cmake3' in building instructions for AL2
(since in AL2, cmake3 is installed and the command should start with cmake3)

Call-outs:

Address any potentially confusing code. Is there code added that needs to be cleaned up later? Is there code that is missing because it’s still in development? no

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer? no

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

replaced 'cmake' to 'cmake3' in building instructions for AL2
@lucykorea414 lucykorea414 changed the title update BUILD.md fix: building for AL2 Aug 1, 2024
@lucykorea414
Copy link
Contributor Author

issue: #4680

@dougch
Copy link
Contributor

dougch commented Aug 1, 2024

Right, we're making the incorrect assumption that a symlink was setup, example form our CI script.

The AL2023/FC34+ package does this correctly, so maybe to keep this generic, a comment above the cli instructions: If you're using AL2 either run update-alternatives or ln -s /usr/bin/cmake3 /usr/bin/cmake ?

@lucykorea414
Copy link
Contributor Author

Then should the command sudo ./install_al2_dependencies.sh be run before the building commands?

@lrstewart
Copy link
Contributor

Then should the command sudo ./install_al2_dependencies.sh be run before the building commands?

No, that script is just for our CI. We shouldn't be telling users to call it.

I'm also not sure we should require users to setup symlinks for our basic build instructions. It seems easy enough to have separate build instructions for AL2 vs AL2023, and to explicitly use cmake3 for AL2 like @lucykorea414 is doing. Is there any reason not to just use cmake3 explicitly, if that's what works on AL2?

@lucykorea414
Copy link
Contributor Author

also, I added in the issue #4680 some commands related to changing the directory while building.
This worked for me in my AL2 EC2 instance.

docs/BUILD.md Outdated Show resolved Hide resolved
lucykorea414 and others added 2 commits August 9, 2024 14:36
Co-authored-by: maddeleine <59030281+maddeleine@users.noreply.github.com>
@lrstewart lrstewart enabled auto-merge (squash) August 13, 2024 20:32
@lrstewart lrstewart merged commit de0b39d into aws:main Aug 16, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants