Fix input data used in test_decode_csv #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_decode_csv fails when I run the tests locally. Looking at the implementation of the test I think there's an error in the input data for the second assertion. This commit fixes the input data for the second assertion so that the test passes.
This was referenced Nov 30, 2021
|
Hey @dlesomewhere, Thank you for finding the issue and opening the PR. I finally added CI-Pipeline for code quality and tests in #42, which forced me to fix it directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #38
test_decode_csv fails when I run the tests locally. Looking at
the implementation of the test I think there's an error in the input
data for the second assertion.
Description of changes:
This commit fixes the input data for the second assertion so that the
test passes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.